refactor: Mutil Column Aggregate Function State Serialization Interface #18398
+700
−396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
forsaken628
commented
Jul 23, 2025
| 1 1 1.0 | ||
|
|
||
| # fix me | ||
| # SELECT MAX(a), MIN(b), weighted_avg(a,b) from t; |
There was a problem hiding this comment.
There are some compatibility issues between aggr indexes and udaf.
| @@ -186,8 +186,8 @@ impl SinkAnalyzeState { | |||
| let index: u32 = name.strip_prefix("ndv_").unwrap().parse().unwrap(); | |||
|
|
|||
| let col = col.index(0).unwrap(); | |||
| let col = col.as_binary().unwrap(); | |||
| let hll: MetaHLL = borsh_deserialize_from_slice(col)?; | |||
| let data = col.as_tuple().unwrap()[0].as_binary().unwrap(); | |||
There was a problem hiding this comment.
Does modifying the aggr serialization type cause incompatible persistence files?
forsaken628
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Serializing the Aggregate Function State into multiple columns instead of a single binary column helps to reduce the size of the serialization and reduce io.
Tests
Type of change
This change is